From a3fdd0007c100f48e11b74e33665e58c633a96f2 Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Sun, 7 Jul 2024 14:33:28 +0100
Subject: [PATCH] rewrite URLs to represent instance (#2)

---
 src/lib/client/app.js                         |   5 +-
 src/lib/client/server.js                      |   5 +-
 src/lib/ui/Navigation.svelte                  |   3 +-
 src/lib/ui/post/ActionBar.svelte              |  17 ++-
 src/lib/ui/post/Post.svelte                   |   3 +-
 src/lib/ui/post/ReactionBar.svelte            |  10 +-
 src/routes/+layout.svelte                     |  13 +-
 src/routes/+page.svelte                       |  12 +-
 src/routes/{post/[id] => [server]}/+page.js   |   2 +-
 src/routes/[server]/[account]/+page.js        |   8 +
 src/routes/[server]/[account]/[post]/+page.js |   7 +
 .../[server]/[account]/[post]/+page.svelte    | 143 ++++++++++++++++++
 src/routes/callback/+page.svelte              |   1 -
 src/routes/post/+page.js                      |   5 -
 src/routes/post/[id]/+page.svelte             | 133 ----------------
 15 files changed, 199 insertions(+), 168 deletions(-)
 rename src/routes/{post/[id] => [server]}/+page.js (63%)
 create mode 100644 src/routes/[server]/[account]/+page.js
 create mode 100644 src/routes/[server]/[account]/[post]/+page.js
 create mode 100644 src/routes/[server]/[account]/[post]/+page.svelte
 delete mode 100644 src/routes/post/+page.js
 delete mode 100644 src/routes/post/[id]/+page.svelte

diff --git a/src/lib/client/app.js b/src/lib/client/app.js
index dc549a7..e17ead4 100644
--- a/src/lib/client/app.js
+++ b/src/lib/client/app.js
@@ -18,7 +18,10 @@ app.subscribe(app => {
  */
 function saveApp(app) {
     if (!browser) return;
-    if (!app) localStorage.removeItem(app_name + "_app");
+    if (!app) {
+        localStorage.removeItem(app_name + "_app");
+        return;
+    }
     localStorage.setItem(app_name + "_app", JSON.stringify(app));
 }
 
diff --git a/src/lib/client/server.js b/src/lib/client/server.js
index 91dcd48..6b42ffe 100644
--- a/src/lib/client/server.js
+++ b/src/lib/client/server.js
@@ -73,7 +73,10 @@ export async function createServer(host) {
  */
 function saveServer(server) {
     if (!browser) return;
-    if (!server) localStorage.removeItem(app_name + "_server");
+    if (!server) {
+        localStorage.removeItem(app_name + "_server");
+        return;
+    }
     localStorage.setItem(app_name + "_server", JSON.stringify(server));
 }
 
diff --git a/src/lib/ui/Navigation.svelte b/src/lib/ui/Navigation.svelte
index c3e0abd..6540562 100644
--- a/src/lib/ui/Navigation.svelte
+++ b/src/lib/ui/Navigation.svelte
@@ -88,7 +88,7 @@
         </div>
     </header>
 
-    {#if $logged_in}
+    {#if $account}
     <div id="nav-items">
         <Button label="Timeline"
                 on:click={() => handle_btn("timeline")}
@@ -180,6 +180,7 @@
         </div>
     </div>
     {/if}
+
     <span class="version">
         campfire v{VERSION}
         <br>
diff --git a/src/lib/ui/post/ActionBar.svelte b/src/lib/ui/post/ActionBar.svelte
index 2a08795..ebaccb9 100644
--- a/src/lib/ui/post/ActionBar.svelte
+++ b/src/lib/ui/post/ActionBar.svelte
@@ -1,6 +1,5 @@
 <script>
     import * as api from '$lib/api';
-    import { get } from 'svelte/store';
     import { server } from '$lib/client/server';
     import { app } from '$lib/client/app';
     import { account } from '@cf/store/account';
@@ -20,11 +19,13 @@
     export let post;
 
     async function toggleBoost() {
+        if (!$app || !$app.token) return;
+
         let data;
         if (post.boosted)
-            data = await api.unboostPost(get(server).host, get(app).token, post.id);
+            data = await api.unboostPost($server.host, $app.token, post.id);
         else
-            data = await api.boostPost(get(server).host, get(app).token, post.id);
+            data = await api.boostPost($server.host, $app.token, post.id);
         if (!data) {
             console.error(`Failed to boost post ${post.id}`);
             return;
@@ -34,11 +35,13 @@
     }
 
     async function toggleFavourite() {
+        if (!$app || !$app.token) return;
+
         let data;
         if (post.favourited)
-            data = await api.unfavouritePost(get(server).host, get(app).token, post.id);
+            data = await api.unfavouritePost($server.host, $app.token, post.id);
         else
-            data = await api.favouritePost(get(server).host, get(app).token, post.id);
+            data = await api.favouritePost($server.host, $app.token, post.id);
         if (!data) {
             console.error(`Failed to favourite post ${post.id}`);
             return;
@@ -69,13 +72,13 @@
     <ActionButton type="reply" label="Reply" bind:count={post.reply_count} sound="post" disabled>
         <ReplyIcon/>
     </ActionButton>
-    <ActionButton type="boost" label="Boost" on:click={toggleBoost} bind:active={post.boosted} bind:count={post.boost_count} sound="boost">
+    <ActionButton type="boost" label="Boost" on:click={toggleBoost} bind:active={post.boosted} bind:count={post.boost_count} sound="boost" disabled={!$account}>
         <RepostIcon/>
         <svelte:fragment slot="activeIcon">
             <RepostIcon/>
         </svelte:fragment>
     </ActionButton>
-    <ActionButton type="favourite" label="Favourite" on:click={toggleFavourite} bind:active={post.favourited} bind:count={post.favourite_count}>
+    <ActionButton type="favourite" label="Favourite" on:click={toggleFavourite} bind:active={post.favourited} bind:count={post.favourite_count} disabled={!$account}>
         <FavouriteIcon/>
         <svelte:fragment slot="activeIcon">
             <FavouriteIconFill/>
diff --git a/src/lib/ui/post/Post.svelte b/src/lib/ui/post/Post.svelte
index 7280108..e9778e2 100644
--- a/src/lib/ui/post/Post.svelte
+++ b/src/lib/ui/post/Post.svelte
@@ -1,6 +1,7 @@
 <script>
     import { onMount } from 'svelte';
     import { goto } from '$app/navigation';
+    import { server } from '$lib/client/server';
 
     import BoostContext from './BoostContext.svelte';
     import ReplyContext from './ReplyContext.svelte';
@@ -31,7 +32,7 @@
                 event.ctrlKey)) return;
             if (event.key && event.key !== "Enter") return;
         }
-        goto(`/post/${post.id}`);
+        goto(`/${$server.host}/${post.account.mention}/${post.id}`);
     }
 
     let el;
diff --git a/src/lib/ui/post/ReactionBar.svelte b/src/lib/ui/post/ReactionBar.svelte
index 9e907e6..6ce4433 100644
--- a/src/lib/ui/post/ReactionBar.svelte
+++ b/src/lib/ui/post/ReactionBar.svelte
@@ -2,7 +2,7 @@
     import * as api from '$lib/api.js';
     import { server, capabilities } from '$lib/client/server.js';
     import { app } from '$lib/client/app.js';
-    import { get } from 'svelte/store';
+    import { account } from '@cf/store/account';
     import { parseReactions } from '$lib/post.js';
 
     import ReactionButton from './ReactionButton.svelte';
@@ -11,6 +11,8 @@
     export let post;
 
     async function toggleReaction(reaction) {
+        if (!$app || !$app.token) return;
+
         if (
             reaction.name.includes('@') &&
             !$server.capabilities.includes(capabilities.FOREIGN_REACTIONS)
@@ -18,9 +20,9 @@
 
         let data;
         if (reaction.me)
-            data = await api.unreactPost(get(server).host, get(app).token, post.id, reaction.name);
+            data = await api.unreactPost($server.host, $app.token, post.id, reaction.name);
         else
-            data = await api.reactPost(get(server).host, get(app).token, post.id, reaction.name);
+            data = await api.reactPost($server.host, $app.token, post.id, reaction.name);
         if (!data) {
             console.error(`Failed to favourite post ${post.id}`);
             return;
@@ -39,7 +41,7 @@
                 on:click={() => toggleReaction(reaction)}
                 bind:active={reaction.me}
                 bind:count={reaction.count}
-                disabled={reaction.name.includes('@') && !$server.capabilities.includes(capabilities.FOREIGN_REACTIONS)}
+                disabled={!$account || (reaction.name.includes('@') && !$server.capabilities.includes(capabilities.FOREIGN_REACTIONS))}
                 title={reaction.name}
                 label="">
                 {#if reaction.url}
diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte
index df928b4..9b2964b 100644
--- a/src/routes/+layout.svelte
+++ b/src/routes/+layout.svelte
@@ -6,7 +6,6 @@
     import { account, logged_in } from '$lib/stores/account.js';
     import { parseAccount } from '$lib/account.js';
     import { unread_notif_count, last_read_notif_id } from '$lib/notifications.js';
-    import { get } from 'svelte/store';
 
     import Navigation from '$lib/ui/Navigation.svelte';
     import Modal from '@cf/ui/Modal.svelte';
@@ -16,25 +15,25 @@
     let show_composer = false;
 
     async function init() {
-        if (!get(app) || !get(app).token) {
+        if (!$app || !$app.token) {
             account.set(false);
             logged_in.set(false);
             return;
         }
 
         // logged in- attempt to retrieve using token
-        const data = await api.verifyCredentials(get(server).host, get(app).token);
+        const data = await api.verifyCredentials($server.host, $app.token);
         if (!data) return;
 
         account.set(parseAccount(data));
         logged_in.set(true);
-        console.log(`Logged in as @${get(account).username}@${get(account).host}`);
+        console.log(`Logged in as @${$account.username}@${$account.host}`);
 
         // spin up async task to fetch notifications
         const notif_data = await api.getNotifications(
-            get(server).host,
-            get(app).token,
-            get(last_read_notif_id)
+            $server.host,
+            $app.token,
+            $last_read_notif_id
         );
 
         if (!notif_data) return;
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index 8d86e4e..e51ef77 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -1,15 +1,15 @@
 <script>
     import { page } from '$app/stores';
     import { get } from 'svelte/store';
-    import { logged_in } from '$lib/stores/account.js';
+    import { account } from '$lib/stores/account.js';
     import { timeline, getTimeline } from '$lib/timeline.js';
 
     import LoginForm from '$lib/ui/LoginForm.svelte';
     import Button from '$lib/ui/Button.svelte';
     import Post from '$lib/ui/post/Post.svelte';
 
-    logged_in.subscribe(logged_in => {
-        if (logged_in) getTimeline();
+    account.subscribe(account => {
+        if (account) getTimeline();
     });
 
     document.addEventListener("scroll", () => {
@@ -20,13 +20,13 @@
     });
 </script>
 
-{#if $logged_in}
+{#if $account}
     <header>
         <h1>Home</h1>
         <nav>
             <Button centered active>Home</Button>
-                <Button centered disabled>Local</Button>
-                <Button centered disabled>Federated</Button>
+            <Button centered disabled>Local</Button>
+            <Button centered disabled>Federated</Button>
         </nav>
     </header>
 
diff --git a/src/routes/post/[id]/+page.js b/src/routes/[server]/+page.js
similarity index 63%
rename from src/routes/post/[id]/+page.js
rename to src/routes/[server]/+page.js
index 9291873..bc936af 100644
--- a/src/routes/post/[id]/+page.js
+++ b/src/routes/[server]/+page.js
@@ -1,5 +1,5 @@
 export async function load({ params }) {
     return {
-        post_id: params.id
+        server_domain: params.server
     };
 }
diff --git a/src/routes/[server]/[account]/+page.js b/src/routes/[server]/[account]/+page.js
new file mode 100644
index 0000000..edbfd18
--- /dev/null
+++ b/src/routes/[server]/[account]/+page.js
@@ -0,0 +1,8 @@
+import { error } from '@sveltejs/kit';
+
+export async function load({ params }) {
+    return error(404, 'Not Found');
+    // return {
+    //     account_name: params.account
+    // };
+}
diff --git a/src/routes/[server]/[account]/[post]/+page.js b/src/routes/[server]/[account]/[post]/+page.js
new file mode 100644
index 0000000..0cd52c3
--- /dev/null
+++ b/src/routes/[server]/[account]/[post]/+page.js
@@ -0,0 +1,7 @@
+export async function load({ params }) {
+    return {
+        server_host: params.server,
+        account_handle: params.account,
+        post_id: params.post
+    };
+}
diff --git a/src/routes/[server]/[account]/[post]/+page.svelte b/src/routes/[server]/[account]/[post]/+page.svelte
new file mode 100644
index 0000000..ed6a050
--- /dev/null
+++ b/src/routes/[server]/[account]/[post]/+page.svelte
@@ -0,0 +1,143 @@
+<script>
+    import * as api from '$lib/api.js';
+    import { server, createServer } from '$lib/client/server.js';
+    import { app } from '$lib/client/app.js';
+    import { parsePost } from '$lib/post.js';
+    import { goto, afterNavigate } from '$app/navigation';
+    import { base as previous_page } from '$app/paths'
+
+    import Post from '$lib/ui/post/Post.svelte';
+    import Button from '$lib/ui/Button.svelte';
+
+    export let data;
+
+    let post;
+    let error = false;
+
+    if (($server && $server.host === data.server_host) && $app) {
+        post = fetchPost(data.post_id, $app.token);
+    } else {
+        post = createServer(data.server_host).then(new_server => {
+            server.set(new_server);
+            if (!$server) {
+                error = `Failed to connect to <code>${data.server_host}</code>.`;
+                console.error(`Failed to connect to ${data.server_host}.`);
+                return;
+            }
+            return post = fetchPost(data.post_id, null);
+        });
+    }
+
+    afterNavigate(({from}) => {
+        previous_page = from?.url.pathname || previous_page
+    })
+
+    async function fetchPost(post_id, token) {
+        const post_data = await api.getPost($server.host, token, post_id);
+        if (!post_data || post_data.error) {
+            error = `Failed to retrieve post <code>${post_id}</code>.`;
+            console.error(`Failed to retrieve post ${post_id}.`);
+            return;
+        }
+        let post = await parsePost(post_data, 0);
+
+        const post_context = await api.getPostContext($server.host, token, post_id);
+
+        if (!post_context || !post_context.ancestors || !post_context.descendants)
+            return post;
+
+        // handle ancestors (above post)
+        let thread_top = post;
+        while (post_context.ancestors.length > 0) {
+            thread_top.reply = await parsePost(post_context.ancestors.pop(), 0);
+            thread_top = thread_top.reply;
+        }
+
+        // handle descendants (below post)
+        post.replies = [];
+        for (let i in post_context.descendants) {
+            post.replies.push(parsePost(post_context.descendants[i], 0));
+        }
+
+        return post;
+    }
+</script>
+
+{#await post}
+    <div class="loading throb">
+        <span>loading post...</span>
+    </div>
+{:then post}
+    {#if error}
+        <p>{@html error}</p>
+    {:else}
+        <header>
+            {#if previous_page}
+                <nav>
+                    <Button centered on:click={() => {goto(previous_page)}}>Back</Button>
+                </nav>
+            {/if}
+            <img src={post.account.avatar_url} type={post.account.avatar_type || "image/png"} alt="" width="40" height="40" class="header-avatar" loading="lazy" decoding="async">
+            <h1>
+                Post by {@html post.account.rich_name}
+            </h1>
+        </header>
+        
+        <div id="feed" role="feed">
+            <Post post_data={post} focused />
+            <br>
+            {#each post.replies as reply}
+                {#await reply then reply}
+                    <Post post_data={reply} />
+                {/await}
+            {/each}
+        </div>
+    {/if}
+{/await}
+
+<style>
+    header {
+        width: 100%;
+        height: 64px;
+        margin: 16px 0 8px 0;
+        display: flex;
+        flex-direction: row;
+    }
+
+    header .header-avatar {
+        width: 40px;
+        height: 40px;
+        margin: auto 0;
+        border-radius: 4px;
+    }
+
+    header h1 {
+        margin: auto auto auto 8px;
+        font-size: 1.5em;
+        text-overflow: ellipsis;
+        overflow: hidden;
+        white-space: nowrap;
+    }
+
+    header nav {
+        margin-right: 8px;
+        display: flex;
+        flex-direction: row;
+        align-items: center;
+        gap: 8px;
+    }
+
+    #feed {
+        margin-bottom: 20vh;
+    }
+
+    .loading {
+        width: 100%;
+        height: 80vh;
+        display: flex;
+        justify-content: center;
+        align-items: center;
+        font-size: 2em;
+        font-weight: bold;
+    }
+</style>
diff --git a/src/routes/callback/+page.svelte b/src/routes/callback/+page.svelte
index 6651619..2f0921e 100644
--- a/src/routes/callback/+page.svelte
+++ b/src/routes/callback/+page.svelte
@@ -19,7 +19,6 @@
         api.getToken(get(server).host, get(app).id, get(app).secret, auth_code).then(token => {
             if (!token) {
                 error(400, { message: "Invalid auth code provided" });
-                return;
             }
 
             app.update(app => {
diff --git a/src/routes/post/+page.js b/src/routes/post/+page.js
deleted file mode 100644
index c0ac9bd..0000000
--- a/src/routes/post/+page.js
+++ /dev/null
@@ -1,5 +0,0 @@
-import { error } from '@sveltejs/kit';
-
-export function load(event) {
-    error(404, 'Not Found');
-}
diff --git a/src/routes/post/[id]/+page.svelte b/src/routes/post/[id]/+page.svelte
deleted file mode 100644
index c0b2379..0000000
--- a/src/routes/post/[id]/+page.svelte
+++ /dev/null
@@ -1,133 +0,0 @@
-<script>
-    import * as api from '$lib/api.js';
-    import { logged_in } from '$lib/stores/account.js';
-    import { server } from '$lib/client/server.js';
-    import { app } from '$lib/client/app.js';
-    import { parsePost } from '$lib/post.js';
-    import { get } from 'svelte/store';
-    import { goto, afterNavigate } from '$app/navigation';
-    import { base } from '$app/paths'
-
-    import Post from '$lib/ui/post/Post.svelte';
-    import Button from '$lib/ui/Button.svelte';
-
-    export let data;
-    let error = false;
-
-    if (!get(logged_in)) goto("/");
-
-    let previous_page = base;
-
-    afterNavigate(({from}) => {
-        previous_page = from?.url.pathname || previous_page
-    })
-
-    $: post = (async resolve => {
-        const post_data = await api.getPost(get(server).host, get(app).token, data.post_id);
-        if (!post_data) {
-            error = `Failed to retrieve post <code>${data.post_id}</code>.`;
-            console.error(`Failed to retrieve post ${data.post_id}.`);
-            return;
-        }
-        let post = await parsePost(post_data, 0);
-
-        const post_context = await api.getPostContext(get(server).host, get(app).token, data.post_id);
-
-        if (!post_context || !post_context.ancestors || !post_context.descendants)
-            return post;
-
-        // handle ancestors (above post)
-        let thread_top = post;
-        while (post_context.ancestors.length > 0) {
-            thread_top.reply = await parsePost(post_context.ancestors.pop(), 0);
-            thread_top = thread_top.reply;
-        }
-
-        // handle descendants (below post)
-        post.replies = [];
-        for (let i in post_context.descendants) {
-            post.replies.push(parsePost(post_context.descendants[i], 0));
-        }
-
-        return post;
-    })();
-</script>
-
-{#if !error}
-<header>
-    {#await post then post}
-        <nav>
-            <Button centered on:click={() => {goto(previous_page)}}>Back</Button>
-        </nav>
-        <img src={post.account.avatar_url} type={post.account.avatar_type} alt="" width="40" height="40" class="header-avatar" loading="lazy" decoding="async">
-        <h1>
-            Post by {@html post.account.rich_name}
-        </h1>
-    {/await}
-</header>
-
-<div id="feed" role="feed">
-    {#await post}
-        <div class="loading throb">
-            <span>loading post...</span>
-        </div>
-    {:then post}
-        <Post post_data={post} focused />
-        <br>
-        {#each post.replies as reply}
-            {#await reply then reply}
-                <Post post_data={reply} />
-            {/await}
-        {/each}
-    {/await}
-</div>
-{:else}
-    <p>{@html error}</p>
-{/if}
-
-<style>
-    header {
-        width: 100%;
-        height: 64px;
-        margin: 16px 0 8px 0;
-        display: flex;
-        flex-direction: row;
-    }
-
-    header .header-avatar {
-        width: 40px;
-        height: 40px;
-        margin: auto 0;
-        border-radius: 4px;
-    }
-
-    header h1 {
-        margin: auto auto auto 8px;
-        font-size: 1.5em;
-        text-overflow: ellipsis;
-        overflow: hidden;
-        white-space: nowrap;
-    }
-
-    header nav {
-        margin-right: 8px;
-        display: flex;
-        flex-direction: row;
-        align-items: center;
-        gap: 8px;
-    }
-
-    #feed {
-        margin-bottom: 20vh;
-    }
-
-    .loading {
-        width: 100%;
-        height: 80vh;
-        display: flex;
-        justify-content: center;
-        align-items: center;
-        font-size: 2em;
-        font-weight: bold;
-    }
-</style>